[bisq-network/bisq] Add protection tools (#5053)
Stan
notifications at github.com
Tue Jan 5 15:22:19 CET 2021
After manually merging my `add-getmyoffers-api-method` branch's changes (https://github.com/bisq-network/bisq/pull/5056) into a clone of @chimp1984 's PR https://github.com/bisq-network/bisq/pull/5053, I find that `offerFilter.canTakeOffer` is working as expected, at least in the core api.
I don't know how you want to proceed, @chimp1984, but I would do the following:
1. Back out all changes made in core.api for PR https://github.com/bisq-network/bisq/pull/5053 (@chimp1984)
2. Review/Merge PR https://github.com/bisq-network/bisq/pull/5056 (@ghubstan, @sqrrm)
3. Review/Merge PR https://github.com/bisq-network/bisq/pull/5053 (@chimp1984, @sqrrm)
4. Create a new PR to apply the filtering in core api's offers service (@ghubstan)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5053#issuecomment-754665020
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210105/305f6cba/attachment.htm>
More information about the bisq-github
mailing list