[bisq-network/bisq] Add toggle for displaying volume in tradestatistics chart in USD (#5066)

chimp1984 notifications at github.com
Fri Jan 8 22:45:34 CET 2021


Adds a toggle to show trade statistics volume in USD instead of BTC

<img width="1200" alt="Screen Shot 2021-01-08 at 16 43 00" src="https://user-images.githubusercontent.com/54558767/104067205-bbc17f80-51d0-11eb-853a-30a4c14a58f4.png">
<img width="1189" alt="Screen Shot 2021-01-08 at 16 43 06" src="https://user-images.githubusercontent.com/54558767/104067216-bfed9d00-51d0-11eb-80a3-0ab6a7a3832f.png">

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5066

-- Commit Summary --

  * Use List instead of ObservableList, cleanups
  * Cache Volume
  * Cache price and localDateTime
  * Add methods for boolean values
  * Add toggle for showing volume as USD instead of BTC

-- File Changes --

    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (37)
    M core/src/main/java/bisq/core/user/Cookie.java (10)
    M core/src/main/java/bisq/core/user/CookieKey.java (3)
    M core/src/main/resources/i18n/displayStrings.properties (3)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (183)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsViewModel.java (138)
    M desktop/src/main/java/bisq/desktop/main/market/trades/charts/CandleData.java (4)
    M desktop/src/main/java/bisq/desktop/main/market/trades/charts/volume/VolumeBar.java (11)
    M desktop/src/main/java/bisq/desktop/util/DisplayUtils.java (21)
    M desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5066.patch
https://github.com/bisq-network/bisq/pull/5066.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5066
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210108/f3e4c5f0/attachment.htm>


More information about the bisq-github mailing list