[bisq-network/bisq] Show a confirmation of successfully sending BTC or BSQ from wallet (#5071)

James Cox notifications at github.com
Sun Jan 10 03:55:04 CET 2021


As requested, this shows a message of successful sending.
The confirmation details include amount, recipient address and txId.
Includes a link to open txId details in the user's external block explorer.
To be consistent it does the same for both BSQ and BTC.

Fixes #5067 

### Screenshots:

![SendBsqTxId](https://user-images.githubusercontent.com/47253594/104113006-04556780-52bb-11eb-824c-159942d54cee.png)

Note the technicality with sending BSQ is you cannot look up the details in a BSQ explorer until +1 bitcoin confs have passed.

@m52go any thoughts on improving the note text shown in the above popup?

https://github.com/jmacxx/bisq/blob/8f24f0ab9c6d12143c09ecd1bb3bcbaa082bb3e4/core/src/main/resources/i18n/displayStrings.properties#L2699

--- 

![SendBtcTx](https://user-images.githubusercontent.com/47253594/104113008-06b7c180-52bb-11eb-8b82-6adc718ab389.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5071

-- Commit Summary --

  * Show a confirmation of successfully sending BTC or BSQ from wallet

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (7)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (3)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (3)
    A desktop/src/main/java/bisq/desktop/main/overlays/windows/TxDetails.java (65)
    A desktop/src/main/java/bisq/desktop/main/overlays/windows/TxDetailsBsq.java (33)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5071.patch
https://github.com/bisq-network/bisq/pull/5071.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5071
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210109/74c8c948/attachment.htm>


More information about the bisq-github mailing list