[bisq-network/bisq] [WIP] Stub out support for OpenOffer's triggerPrice in api (#5076)

Stan notifications at github.com
Mon Jan 11 18:46:33 CET 2021


This is a feature that will not be included in api v1, but partial support is added with this change to the server.  CLI will pass a default `triggerPrice` of 0 (default, unused) with the `createoffer` command.

When fully implemented, an optional trigger-price param will be  added to the `createoffer` method, and its value will only be visible to the offer owner.  New `enableoffer` and `disableoffer` methods will also need to be added at that time.

This is the 3rd in a chain of PRs, starting with https://github.com/bisq-network/bisq/pull/5063.  
https://github.com/bisq-network/bisq/pull/5065 should be reviewed & merged before this one.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5076

-- Commit Summary --

  * Fix two CLI option parsing bugs
  * Add @Singleton annotation
  * Integrate new protection tools into api's offer & trade services
  * Merge branch 'master' into 03-support-trigger-price
  * Stub out support for OpenOffer's triggerPrice in api

-- File Changes --

    M cli/src/main/java/bisq/cli/CliMain.java (6)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (11)
    M cli/src/main/java/bisq/cli/NegativeNumberOptions.java (22)
    M core/src/main/java/bisq/core/api/CoreApi.java (7)
    A core/src/main/java/bisq/core/api/CoreContext.java (39)
    M core/src/main/java/bisq/core/api/CoreDisputeAgentsService.java (2)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (27)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (2)
    M core/src/main/java/bisq/core/api/CorePriceService.java (3)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (9)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (2)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (25)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (5)
    M proto/src/main/proto/grpc.proto (22)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5076.patch
https://github.com/bisq-network/bisq/pull/5076.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5076
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210111/c732b6d4/attachment.htm>


More information about the bisq-github mailing list