[bisq-network/bisq] Add "Buy BSQ" button next to trade fee selector (#5055)

[Christoph Atteneder]

@ripcurlx commented on this pull request.

I think having on the small green button `Buy BSQ` might confuse noobs what will happen if they click on this.
Maybe it should be something more like `Get BSQ` or `How to get BSQ` 👈  @m52go ?
We could use this popup afterwards not only to push the user to buy BSQ, but also show the possibility to earn BSQ by contributing.

Maybe we could also only show the Buy BSQ button if the trade has insufficient funds to pay the trading fee with BSQ.

Regarding the combobox question. So the goal is to open the offer book to sell BTC and have all BSQ offers selected? Atm it switches to the offer book setting the focus in the currency combobox.


> For the case where someone is selling BTC I think the current sale tab needs to be closed and a new one opened for buying BSQ since there can only be one BTC sell tab open. That could perhaps be a bit confusing but I think allowing for multiple create offer tabs would be more trouble. Perhaps include a warning that the current BTC sell tab will be closed in the popup as well for that case.

That is the current behavior. It will just replace the current `Take offer` tab that was used for selling BTC in the first place. Maybe we just add a `don't show again` popup if a user is trying to take different offers to reduce confusion where the old `take offer` tab vanished to.

> @@ -33,4 +47,26 @@ public static Label createPopOverLabel(String text) {
         label.setPadding(new Insets(10));
         return label;
     }
+
+    public static Tuple2<AutoTooltipButton, VBox> createBuyBsqButtonBox(Navigation navigation, Preferences preferences) {
+        String buyBsqText = Res.get("shared.buyCurrency", "BSQ");
+        var buyBsqButton = new AutoTooltipButton(buyBsqText);
+        buyBsqButton.getStyleClass().add("action-button");
+        buyBsqButton.setStyle("-fx-pref-height: 20; -fx-padding: 3 8 3 8; -fx-font-size: 0.769em; -fx-border-radius: 5;");

Please move this into the css file and use another class instead.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#pullrequestreview-567055236
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210113/07c07ca9/attachment.htm>