[bisq-network/bisq] Avoid reverse DNS lookup in BtcNodeConverterTest (#5083)

Steven Barclay notifications at github.com
Fri Jan 15 17:07:33 CET 2021


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Prevent failure of `testConvertClearNode()` on some machines, caused by use of `InetAddress.getHostName` on the mock peer address. This does a reverse DNS lookup and potentially returns something other than the expected "192.168.0.1" string. (For example, on my current local network I get "BrightBox.ee".)

Also avoid an unnecessary `getHostName()` call on the SOCKS5 Tor proxy InetAddress in `WalletConfig`, by using an alternative `InetSocketAddress` constructor.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5083

-- Commit Summary --

  * Avoid reverse DNS lookup in BtcNodeConverterTest

-- File Changes --

    M core/src/main/java/bisq/core/btc/setup/WalletConfig.java (3)
    M core/src/test/java/bisq/core/btc/nodes/BtcNodeConverterTest.java (5)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5083.patch
https://github.com/bisq-network/bisq/pull/5083.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5083
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210115/1730eb7a/attachment.htm>


More information about the bisq-github mailing list