[bisq-network/bisq] Reword "trade started" popup messages per suggestion (#5091)

jmacxx notifications at github.com
Tue Jan 19 00:16:20 CET 2021


**This PR implements @m52go's suggested simplification.**

> ^ there is a lot of text on this screen...this reduces the chance that the user reads any of it.
> I'm not sure the parts on multiple confirmations, bank details, copy/paste, etc. are that important.
> Suggestion to simplify:

    Your trade has reached at least 1 blockchain confirmation.
    Please pay 303 EUR via the specified payment method to the BTC seller. You'll find the seller's account details on the next screen.
    Important: when making the payment, leave the "reason for payment" field empty. DO NOT put the trade ID or any other text like 'bitcoin', 'BTC', or 'Bisq'.
    If your bank charges you any fees to make the transfer, you are responsible for paying those fees.


https://github.com/bisq-network/bisq/pull/5080#issuecomment-759932866

And 

>I agree, but I would prefer to keep that for another PR. There are more popup text to improve but as the text is composed of several blocks depending on payment method its also not that trivial and need then better testing with the diff. payment methods.
> Any dev who wants to pick that up?

https://github.com/bisq-network/bisq/pull/5080#issuecomment-759939397

----

Here is a set of screenshots showing how each popup looks:  [trade_popups.pdf](https://github.com/bisq-network/bisq/files/5832703/trade_popups.pdf).  It includes FasterPayments, Cash Desposit, Moneygram, HalCash, Altcoins, F2F, Zelle, Transferwise, Amazon, USPSMO, Sepa.

Here's one example:
![image](https://user-images.githubusercontent.com/47253594/104970090-f769ff80-59af-11eb-9abd-b7a1e1a211bd.png)

----

*Please note I had to implement on PR #5080, so those commits are also included here.  I presume #5080 will be merged prior to this.  Hopefully git will handle things intelligently.*


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5091

-- Commit Summary --

  * Remove instructions for using trade id as reason for payment
  * Add popup at startup to notify about rule change if user had already a fiat account
  * Improve text, reformat tac text
  * Update core/src/main/resources/i18n/displayStrings.properties
  * Update core/src/main/resources/i18n/displayStrings.properties
  * Update desktop/src/main/java/bisq/desktop/main/overlays/windows/TacWindow.java
  * Reword trade started popups per @m52go suggestion

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (25)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (21)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TacWindow.java (14)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (65)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (21)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5091.patch
https://github.com/bisq-network/bisq/pull/5091.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5091
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210118/adf14007/attachment.htm>


More information about the bisq-github mailing list