[bisq-network/bisq] Add payment method "Cash by mail" (#5092)

[jmacxx]

Closes #1101 

This is built on top of #5080 and #5091.
The code for this PR is contained in https://github.com/bisq-network/bisq/commit/e11209d395bfcea22b7bfd07d38f6137c6144664

----

![image](https://user-images.githubusercontent.com/47253594/104983679-de267a80-59d2-11eb-9c2d-583bae1e73ac.png)

----

![image](https://user-images.githubusercontent.com/47253594/104983611-b800da80-59d2-11eb-8f1b-f805f5c4e19f.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5092

-- Commit Summary --

  * Remove instructions for using trade id as reason for payment
  * Add popup at startup to notify about rule change if user had already a fiat account
  * Improve text, reformat tac text
  * Update core/src/main/resources/i18n/displayStrings.properties
  * Update core/src/main/resources/i18n/displayStrings.properties
  * Update desktop/src/main/java/bisq/desktop/main/overlays/windows/TacWindow.java
  * Reword trade started popups per @m52go suggestion
  * Fix apostrophe; add message about discussing reason for payment text.
  * Add payment method "Cash by mail"

-- File Changes --

    M core/src/main/java/bisq/core/offer/Offer.java (4)
    M core/src/main/java/bisq/core/offer/OfferPayload.java (1)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (5)
    A core/src/main/java/bisq/core/payment/CashByMailAccount.java (56)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (2)
    A core/src/main/java/bisq/core/payment/payload/CashByMailAccountPayload.java (124)
    M core/src/main/java/bisq/core/payment/payload/F2FAccountPayload.java (2)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (3)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (3)
    M core/src/main/resources/i18n/displayStrings.properties (59)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/CashByMailForm.java (159)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/F2FForm.java (8)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (21)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (19)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (11)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TacWindow.java (14)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (73)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (23)
    M desktop/src/main/java/bisq/desktop/util/validation/EmailValidator.java (2)
    M proto/src/main/proto/pb.proto (7)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5092.patch
https://github.com/bisq-network/bisq/pull/5092.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5092
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210118/9934bb71/attachment.htm>