[bisq-network/bisq] Implement Segwit for BSQ (#5000)

[sqrrm]

@sqrrm commented on this pull request.



> +
+import java.util.List;
+
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+ at Data
+ at NoArgsConstructor
+ at JsonInclude(JsonInclude.Include.NON_NULL)
+ at JsonIgnoreProperties(ignoreUnknown = true, value = "ntx")
+ at JsonPropertyOrder({"hash", "confirmations", "strippedsize", "size", "weight", "height", "version", "versionHex",
+        "merkleroot", "tx", "time", "mediantime", "nonce", "bits", "difficulty", "chainwork", "nTx",
+        "previousblockhash", "nextblockhash"})
+public class RawBlock {

Yeah, I think that would make it clearer, adding a dto prefix or infix for each of the dto classes would make it clear what's going on. It is mostly clear as the variable names you've used include dto, but even better if the class names themselves also adhered to that pattern.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5000#discussion_r561769245
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210121/7505cf39/attachment.htm>