[bisq-network/bisq] Manual payout tool: prevent absurdly high fee payout (#5099)

chimp1984 notifications at github.com
Thu Jan 21 21:03:57 CET 2021


@chimp1984 requested changes on this pull request.



> @@ -544,6 +553,8 @@ private void calculateTxFee() {
                     .subtract(getInputFieldAsCoin(buyerPayoutAmount))
                     .subtract(getInputFieldAsCoin(sellerPayoutAmount));
             txFee.setText(txFeeValue.toPlainString());
+            double feePercent = (double) txFeeValue.value / getInputFieldAsCoin(amountInMultisig).value;

Maybe safer to wrap it into a try catch? E.g. if getInputFieldAsCoin(amountInMultisig).value can be 0 it would throw an exception.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5099#pullrequestreview-573691553
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210121/56ebe597/attachment.htm>


More information about the bisq-github mailing list