[bisq-network/bisq] New Feature: Pre-release notifications (#5108)

jmacxx notifications at github.com
Sat Jan 23 03:40:30 CET 2021


Fixes #4532

Adds the ability for pre-release notifications to be sent by the admin key holder.
Users have the option in Settings to subscribe for pre-release notifications.  (Default=off).

---

### Screenshots

Generating a pre-release notification:

![image](https://user-images.githubusercontent.com/47253594/105566180-5ef5b700-5cf0-11eb-9d81-63ea00ce2202.png)


User setting for subscribing to pre-release notifications:

![image](https://user-images.githubusercontent.com/47253594/105566191-6e750000-5cf0-11eb-8fd1-5f92740ed742.png)


Notification of a pre-release:

![image](https://user-images.githubusercontent.com/47253594/105566218-9c5a4480-5cf0-11eb-9a9d-17bb7a268281.png)


Notification link is shown in the footer bar (if subscribed) :

![image](https://user-images.githubusercontent.com/47253594/105566256-c7449880-5cf0-11eb-9938-6e6cda407514.png)

---

### Testing matrix for alert messages:

The alert can be either a regular release notification, a pre-release notification, or simply an general-purpose message.  This is a list of tests performed:

* Verify that a general text alert message can be sent by old and new clients.
* Verify that a general text alert message can be received by old and new clients.
* Verify that a general text alert message can be removed by old and new clients.
* Verify that a software release message can be sent by old and new clients.
* Verify that a software release message can be received by old and new clients.
* Verify that a software release message can be removed by old and new clients.
* Verify that a software PRE-release message can be sent by new clients.
* Verify that a software PRE-release message can be received by new clients.
* Verify that a software PRE-release message can be removed by new clients.
* Verify that a software PRE-release message does not affect old clients (it is not seen).
* Verify that a software PRE-release message removal does not affect old clients.
* Verify that a software PRE-release message followed by a software release message for the same version is handled correctly.
* Verify that the PRE-release message only pops up on clients that have opted-in via the User Preferences setting.
* Verify that the footer PRE-release notification link only shows up on clients that have opted-in via the User Preferences setting.
* Verify that if user responds with "Ignore this version" option the software release message is not shown again upon startup.
* Verify that if user responds with "Ignore this version" option the software pre-release message is not shown again upon startup.

 

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5108

-- Commit Summary --

  * Add pre-release software update notifications
  * code cleanup

-- File Changes --

    M core/src/main/java/bisq/core/alert/Alert.java (34)
    M core/src/main/java/bisq/core/app/BisqSetup.java (27)
    M core/src/main/java/bisq/core/user/Preferences.java (7)
    M core/src/main/java/bisq/core/user/PreferencesPayload.java (7)
    M core/src/main/resources/i18n/displayStrings.properties (5)
    M core/src/test/java/bisq/core/user/UserPayloadModelVOTest.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisplayAlertMessageWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SendAlertMessageWindow.java (31)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (8)
    M proto/src/main/proto/pb.proto (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5108.patch
https://github.com/bisq-network/bisq/pull/5108.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5108
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210122/8715dc6b/attachment-0001.htm>


More information about the bisq-github mailing list