[bisq-network/bisq] Specify Amazon eGift Card country (#5117)

jmacxx notifications at github.com
Tue Jan 26 05:21:42 CET 2021


Fixes #5098

- Adds countryCode to AmazonGiftCardAccountPayload
- Displays a reminder to the user to replace their old AmazonGiftCard account (due to new field).
- Offers cannot be created or taken using the old account.
- Trade buyer step 2 prompts use of the appropriate Amazon website for buying gift card.
 
---
Example: A French person buying BTC from German person.

![image](https://user-images.githubusercontent.com/47253594/105799211-93b87700-5f59-11eb-9516-f29e65f365eb.png)

---

![image](https://user-images.githubusercontent.com/47253594/105799919-3a514780-5f5b-11eb-9cb8-9413ae0b3a8a.png)

---

![image](https://user-images.githubusercontent.com/47253594/105798712-67e8c180-5f58-11eb-9b7a-d6df38b3fa29.png)

![image](https://user-images.githubusercontent.com/47253594/105798792-9070bb80-5f58-11eb-9379-70d1068fee75.png)

---

![image](https://user-images.githubusercontent.com/47253594/105798848-b007e400-5f58-11eb-9f60-a45eaec3c46e.png)

![image](https://user-images.githubusercontent.com/47253594/105798865-beee9680-5f58-11eb-9604-bebd91812642.png)


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5117

-- Commit Summary --

  * Specify Amazon eGift Card country

-- File Changes --

    M core/src/main/java/bisq/core/locale/BankUtil.java (38)
    M core/src/main/java/bisq/core/locale/CountryUtil.java (10)
    M core/src/main/java/bisq/core/payment/AmazonGiftCardAccount.java (23)
    M core/src/main/java/bisq/core/payment/payload/AmazonGiftCardAccountPayload.java (10)
    M core/src/main/java/bisq/core/payment/payload/PaymentAccountPayload.java (4)
    M core/src/main/resources/i18n/displayStrings.properties (12)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/AmazonGiftCardForm.java (54)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsDataModel.java (30)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (4)
    M proto/src/main/proto/pb.proto (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5117.patch
https://github.com/bisq-network/bisq/pull/5117.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210125/0f963896/attachment-0001.htm>


More information about the bisq-github mailing list