[bisq-network/bisq] Fix stale trade statistics list view when new entries arrive (#5122)

Steven Barclay notifications at github.com
Wed Jan 27 22:21:39 CET 2021


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Ensure the trade statistics list in `TradesChartsView` doesn't go stale upon new statistics arrivals, by moving a `fillList()` call from the _onChangeConfirmed_ currency combobox event handler to the listener of the `selectedTradeStatistics` `TradesChartsViewModel` field.

(Also avoid unnecessary use of an `ObservableList` as a temporary variable in the `fillList()` method.)

--

I first spotted this bug a little while ago and it appears to have been present since early November 2020, at least looking through the commit history, so it most likely affects both master and the current v1.5.5 release candidate.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5122

-- Commit Summary --

  * Fix stale trade stats list view when new entries arrive

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (21)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5122.patch
https://github.com/bisq-network/bisq/pull/5122.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5122
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210127/144b7898/attachment.htm>


More information about the bisq-github mailing list