[bisq-network/bisq] Add mempool lookup for trade transactions (#5119)

[chimp1984]

Not sure I understand correctly:
Accepted in the mempool does not mean that the miner fee was high enough to get included in a block. 
So we could publish the offer only once it is confirmed but that might come with considerable delays and I fear that has too much of a downside and it also does not mean the the other trade txs will get confirmed, so in times of volatile fees it still could lead to failed trades and the mess with required SPV resync to clean up the wallet.
 
> If the transactions did not get accepted in the mempool for any reason, trade would fail but no funds would be lost.

The taker might lose the taker fee and it causes likely a support case.

I think what you aim for is to have a queue of new offers where you define the max tx fee you want to pay and those get published once the mempool is empty so that they have good chances to get confirmed. That could be done by keeping those offers locally in a queue and regularily check the recommended miner fee and once it is below your preferred miner fee they get published with the maker fee.
That is conceptually do-able but not a trivial dev effort.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5119#issuecomment-768753448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210127/b9582813/attachment.htm>