[bisq-network/bisq] Add mempool lookup for trade transactions (#5119)

chimp1984 notifications at github.com
Thu Jan 28 04:04:45 CET 2021


> At least no active trades would fail due to maker tx id not being published.

Yes. But I fear the trade off to always delay an offer to the risk that we get a congested mempool and an offer is never get confirmed is maybe not a good one. I think when we remove the risk for failed txs not included in the mempool we have solved the most critical problem. 

Another option could be to add the maker fee (sat/vbyte) in the offer and handle it client side to filter/ignore offers with unconfirmed maker txs with a very low fee as those carry higher risk of delayed or never confirmed deposit txs. Though that would increase complexity for user how to interpret that data, so probably not a good idea...

We could also add the option for takers to only accpet offers where the maker fee is confirmed.

To make an explorer lookup for all offers might be a bit expensive as well, so probably better to limit it to offers the taker is intending to take. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5119#issuecomment-768765140
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210127/83a37493/attachment.htm>


More information about the bisq-github mailing list