[bisq-network/bisq] Make some trade simulation functions re-usable (#5128)

[Stan]

Code duplication needs to be reduced as new scripts are added.

- Refactor the `createpaymentacct` functions.
  The steps required to create a payment account are still displayed, but only for Alice, not Bob.

- Treat the trade protocol simulation as an atomic function.
  This will reduce 'main' simulation script size as new ones are added.
  
- Move `createoffer` command generation to its own function. 

This PRs branch was created off `01-fix-bash-syntax`, and https://github.com/bisq-network/bisq/pull/5116 needs to be reviewed and merged before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5128

-- Commit Summary --

  * Fix bash syntax inconsistencies
  * Refactor createpaymentacct and trade protocol functions

-- File Changes --

    M apitest/scripts/limit-order-simulation.sh (87)
    M apitest/scripts/trade-simulation-env.sh (32)
    M apitest/scripts/trade-simulation-utils.sh (187)
    M apitest/scripts/trade-simulation.sh (188)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5128.patch
https://github.com/bisq-network/bisq/pull/5128.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5128
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210128/0312b432/attachment.htm>