[bisq-network/bisq] New Feature: Pre-release notifications (#5108)

chimp1984 notifications at github.com
Fri Jan 29 02:44:53 CET 2021


@chimp1984 approved this pull request.

utACK

I assume the alert will fail if the version of the alert sender and the receiver is not the same as a new field got added and the signature check will fail as the hash of the payload is different.
If that is the case (I have not tested it) I think it is also not a big problem, we just need to be aware and Alert sender should use only the old version until most ppl have updated. 
Alternatively we could pack the new data into the extraDataMap, but I think its not worth it for that case. Old users who have not updated for longer time will miss Alerts once the alert sender uses the new version.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5108#pullrequestreview-578881053
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210128/e7ee0984/attachment.htm>


More information about the bisq-github mailing list