[bisq-network/bisq] Speed up deposit and transactions view loads (#5120)
Steven Barclay
notifications at github.com
Fri Jan 29 19:36:15 CET 2021
@stejbac commented on this pull request.
> @@ -408,18 +430,15 @@ public TransactionConfidence getConfidenceForTxId(String txId) {
return null;
}
- protected TransactionConfidence getTransactionConfidence(Transaction tx, Address address) {
- List<TransactionConfidence> transactionConfidenceList = getOutputsWithConnectedOutputs(tx)
- .stream()
- .filter(WalletService::isOutputScriptConvertibleToAddress)
- .filter(output -> address != null && address.equals(getAddressFromOutput(output)))
- .map(o -> tx.getConfidence())
- .collect(Collectors.toList());
- return getMostRecentConfidence(transactionConfidenceList);
+ private TransactionConfidence getTransactionConfidence(Transaction tx, Address address) {
OK, I agree it probably should be `@Nullable`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5120#discussion_r567016685
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210129/cb419d03/attachment.htm>
More information about the bisq-github
mailing list