[bisq-network/bisq] Remove automatic fee setting to avoid bugs/money loss (#5601)

[MatthewCroughan]

If we remove whatever code is responsible for automatic fee setting, then issue https://github.com/bisq-network/bisq/issues/5575 in principal cannot occur, as the only fee value/variable in memory possible to set will be taken from the GUI.

The variable should be initialized to NULL, then look up what the user has set. It should not be set from any other source automatically outside of the user's control.

I would prefer this guarantee to lost money, especially for a wallet as specifically power-user oriented as Bisq.

Instead, can we have a variable that shows a **suggested** fee, rather than setting the fee for the user? It should be required that the user set the fee, in order to avoid possible bugs with the GUI.

It would be better if the default automated fee variable were only set upon hitting the "send transaction" button, rather than being set somewhere in memory *prior* to user interaction, automatically, as seems to be the case intuitively, although I could be wrong about this implementation, it seems logical that this is what is happening.

If the default fee is set prior to user interaction, in a variable that is controlled separately from the GUI, it can lead to this issue in principal.

I do not have the time to look into the code clearly, but my observations might make some sense, I hope they are of use and not completely inaccurate.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5601
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210702/be770cc0/attachment.htm>