[bisq-network/bisq] Fix custom withdrawal fee bug (#5602)

jmacxx notifications at github.com
Sat Jul 3 07:30:39 CEST 2021


Custom withdrawal fee was not being used because the custom withdrawal fee flag was not set.
Fixes #5575
 
 
### Steps to reproduce the issue (regtest)

- Prerequisite: `Use custom withdrawal fee` is unchecked in Settings/Preferences.
- Go to Funds/Receive funds select a receiving address and copy to clipboard.
- Go to Funds/Send funds, paste your address into the withdraw to address field.
- Take note of the default suggested transaction fee (in this case **50 sats/vb**).
- Click use custom value for fee, enter 2 sats/vbyte or the lowest value permissible.
- Click Withdraw Selected.  Note the mining fee and the sats/vb reported alongside it.
- Click yes to withdraw.
- Now go to the log where it details the transaction, note the weight e.g. 110 virtual bytes, and note the fee paid e.g. 0.00055 BTC ( = 55000 sats).
- Divide the fee paid by virtual bytes to get the actual fee per vb paid, in this case 55000 / 110 = **50 sats/vb**.
- The fee used is the value originally shown in the fee text box, instead of the one the user entered.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5602

-- Commit Summary --

  * fix custom withdrawal fee bug

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5602.patch
https://github.com/bisq-network/bisq/pull/5602.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5602
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210702/830c36f9/attachment.htm>


More information about the bisq-github mailing list