[bisq-network/bisq] Optimize DaoState snapshot behaviour (#5609)

sqrrm notifications at github.com
Wed Jul 7 16:39:43 CEST 2021

@sqrrm commented on this pull request.

It looks safe, just want to clarify my confusion with the memory reset order

> +                // After we have written to disk we remove the reference to the daoState. We have in the meantime
+                // already cloned the next daoState and if we would not release the reference we would have 3 times
+                // the daoState data in memory.
+                store.setDaoState(null);

It looks to me like the store is reset before completehandler is called which is where the new clone of daoState is made. Comment makes it seem like the clone is made before store is cleared.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210707/2d18b254/attachment.htm>

More information about the bisq-github mailing list