[bisq-network/bisq] Improve Validation of Deposit Inputs (#5618)

jimmyneutront notifications at github.com
Sun Jul 11 20:15:48 CEST 2021


Improve the accuracy and readability of error messages that arise during the validation of deposit inputs, and stop throwing unnecessary errors when a trade's reserved-for-trade wallet has been funded by an external wallet

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5618

-- Commit Summary --

  * Improve Validation of Deposit Inputs

-- File Changes --

    M core/src/main/java/bisq/core/trade/TradeDataValidation.java (49)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5618.patch
https://github.com/bisq-network/bisq/pull/5618.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5618
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210711/9b566896/attachment.htm>


More information about the bisq-github mailing list