[bisq-network/bisq] Running the numbers on Bisq DAO revenues (#5171)

[chimp1984]

> Is it possible to change this so when DAO is not synced or deactivated just the two addresses below would be used?

No, the default address cannot be changed as that would be a hardfork. 

> I think this address also receives trade fees. For example two recent ones:

Yes, looks like a fee payment. Might be some edge cases (filter not received,...).

> If all the BTC trade fees sent to 38bZBj5peYS3Husdz7AH3gEUiUbYRD951t could be aggregated by a node and displayed on the charts in the DAO that would be great.

Yes agree. Maybe @jmacxx has some headroom for implementing it?

 > The above would work on the assumption that: ....

Yes I think those assumptions are basically right, but there will be some smaller amounts to the old addresses and as you mentioned there might be some fees sent to the del. payout receiver address. But I think the ratio of those are very small so they should not distort the overall number. 

I looked in the past into the issue why the other addresses are still used and did not found a clear reason. My assumption is that it happens with a out dated DAO state of the user, so the last valid address was used. The default address is used when the user has deactivated the DAO but from my recent tests the app is not working if the DAO is deactivated, so that should not be the case as well at least if users use recent versions, which is enforced by last hard fork. So no clear idea why there are still fees sent to those addresses...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5171#discussioncomment-1019382
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210718/5c7b57fc/attachment.htm>