[bisq-network/bisq] Allow LTC accounts to use segwit addresses (#5639)

jmacxx notifications at github.com
Tue Jul 27 06:31:05 CEST 2021


Fixes issue described by a user here:

https://old.reddit.com/r/bisq/comments/omf3l3/cannot_add_ltc_account/

> Under "altcoin accounts" I'm trying to add the address of my LTC core wallet.
> Neither regular nor Bech32 addresses works. Anyone know How I'd go about adding LTC?

---

### Implementation:

- The address validator specified the bitcoin magic number for wrapped segwit, 5 -- it should be 50 for LTC.
- The address validator expected base58 only (legacy format).  Changed to use an address validator that supports bech32 and base58.

### Testing:

Added tests for wrapped segwit and bech32 address formats.

---

![image](https://user-images.githubusercontent.com/47253594/127095521-b79ece9a-be46-423e-ba81-f2ab7c3667ca.png)

![image](https://user-images.githubusercontent.com/47253594/127095172-d2e33bfb-163b-48b1-8ecb-df7114d4deed.png)




You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5639

-- Commit Summary --

  * allow LTC accounts to use segwit addresses

-- File Changes --

    M assets/src/main/java/bisq/asset/coins/Litecoin.java (7)
    M assets/src/test/java/bisq/asset/coins/LitecoinTest.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5639.patch
https://github.com/bisq-network/bisq/pull/5639.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5639
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210726/3ba64d44/attachment-0001.htm>


More information about the bisq-github mailing list