[bisq-network/bisq] Improve Chat message reliability (#5551)
notifications at github.com
Wed Jun 2 17:15:26 CEST 2021
As described in #5526, there are cases where network messages get the arrived status but no ACK and the receiver never actually saw the message. This can be cause of confusion because the "arrived" status is generally used by the sender as indication that all is good. The ACK is generally ignored.
To remedy this for Chat messages, this PR displays the sent message as "In transit" until the ACK is received back, or it times out and displays status describing the problem and asking the user to try again. The timeout is 5 seconds. An ACK can still be received after 5 seconds, in which case the status will update to show that the message arrived.
Sent the message, waiting for the ACK:
ACK received back:
No ACK received back:
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* ChatMessage show error if no ACK received
-- File Changes --
M core/src/main/java/bisq/core/support/messages/ChatMessage.java (12)
M core/src/main/resources/i18n/displayStrings.properties (2)
M desktop/src/main/java/bisq/desktop/main/shared/ChatView.java (6)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github