[bisq-network/bisq] Check BTC node config without IO overhead (#4081)
Kai
notifications at github.com
Mon Jun 7 11:38:04 CEST 2021
@KaiWitt commented on this pull request.
> + var wellConfigured = isWellConfigured(versionMessage);
+ if (wellConfigured) {
A temp variable is not necessary imo, the method call is already very concise and readable
```suggestion
if (isWellConfigured(versionMessage)) {
```
> + if (wellConfigured) {
+ log.info("Peer well configured: {}", peer);
+ } else {
Redundant `else` clause bc the `if` can return. Makes it more readable
```suggestion
if (wellConfigured) {
log.info("Peer well configured: {}", peer);
return;
}
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4081#pullrequestreview-677182177
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210607/754019cd/attachment.htm>
More information about the bisq-github
mailing list