[bisq-network/bisq] Check BTC node config without IO overhead (#4081)

dmos62 notifications at github.com
Mon Jun 7 15:35:36 CEST 2021


@dmos62 commented on this pull request.



> +        var wellConfigured = isWellConfigured(versionMessage);
+        if (wellConfigured) {

A variable defining the condition is a style I use (and propagate) and, even if the called method is descriptive as well, I still use it. One reason is consistency of style. Another, the if statement doesn't care that the node being well configured is predicated on the version message (that's an implemenation detail), so there's no reason to put that in the if statement. I would be against your suggestion, because it optimizes for terseness at the cost of readability.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4081#discussion_r646593194
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210607/de95a079/attachment.htm>


More information about the bisq-github mailing list