[bisq-network/bisq] Check BTC node config without IO overhead (#4081)

dmos62 notifications at github.com
Mon Jun 7 15:44:00 CEST 2021

@dmos62 commented on this pull request.

> +        if (wellConfigured) {
+            log.info("Peer well configured: {}", peer);
+        } else {

If you don't remove the `wellConfigured` intermediary variable as you suggested above (which I am against), this originally reads "if the node is well configured log that, else perform following steps", which is favourable over your suggetion: "if the node is well configured, given provided version message, exit the method, foregoing steps that would only be executed in case the node were not well configured." Your edits have a negative effect on readability and a very minimal effect on terseness, which, in my opinion, should not be a consideration anyway (but that's besides the point).

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210607/8ec4c7e0/attachment.htm>

More information about the bisq-github mailing list