[bisq-network/bitcoinj] Clone transaction before committing to wallet (#37)

sqrrm notifications at github.com
Wed Jun 9 14:29:14 CEST 2021


This is basically the same PR as https://github.com/bisq-network/bitcoinj/pull/21 but it's now a real issue. This PR also clones `purpose` which wasn't done in the earlier PR.

Atomic transactions that have inputs and outputs relating to two wallets are received from the network and added through `receivePending()`. To avoid adding the same instance of a transaction to two wallets a clone is made and added instead. These transactions come from the network so they don't yet have any wallet data associated with them.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bitcoinj/pull/37

-- Commit Summary --

  * Clone transaction before committing to wallet

-- File Changes --

    M core/src/main/java/org/bitcoinj/wallet/Wallet.java (16)

-- Patch Links --

https://github.com/bisq-network/bitcoinj/pull/37.patch
https://github.com/bisq-network/bitcoinj/pull/37.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/37
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210609/600f7e48/attachment.htm>


More information about the bisq-github mailing list