[bisq-network/bisq] Refactor EditOfferDataModel for new editoffer api method (#5571)

Stan notifications at github.com
Sat Jun 12 23:46:33 CEST 2021


Minor refactoring to avoid duplication in next PR (to add `editoffer` api method).

- Define set of editable offer payload fields in `MutableOfferPayloadFields`.                                              

- Move bulk of `EditOfferDataModel#onPublishOffer` logic to `OfferUtil`.

This is the 2nd in a series of PRs, starting at https://github.com/bisq-network/bisq/pull/5570.

https://github.com/bisq-network/bisq/pull/5570 Should be reviewed/merged before this one. 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5571

-- Commit Summary --

  * Remove commented out test
  * Remove unsupported create CHASE_QUICK_PAY apitest case
  * Refactor EditOfferDataModel for new editoffer api method
  * Fix comment

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/payment/CreatePaymentAccountTest.java (23)
    M apitest/src/test/java/bisq/apitest/scenario/PaymentAccountTest.java (1)
    A core/src/main/java/bisq/core/offer/MutableOfferPayloadFields.java (89)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (47)
    M core/src/test/java/bisq/core/payment/PaymentAccountsTest.java (17)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (49)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5571.patch
https://github.com/bisq-network/bisq/pull/5571.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5571
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210612/c4ab618c/attachment.htm>


More information about the bisq-github mailing list