[bisq-network/bisq] Refactor EditOfferDataModel for new editoffer api method (#5571)

Kai notifications at github.com
Sun Jun 13 11:50:00 CEST 2021


@KaiWitt commented on this pull request.



> +    // Returns an edited payload: a merge of the original offerPayload and
+    // editedOfferPayload fields.  Mutable fields are sourced from
+    // mutableOfferPayloadFields param, e.g., payment account details, price, etc.
+    // Immutable fields are sourced from the original openOffer param.

JavaDoc or it doesn't show up in the documentation popup in your IDE
```suggestion
    /**
     * Returns an edited payload: a merge of the original offerPayload and
     * editedOfferPayload fields. Mutable fields are sourced from
     * mutableOfferPayloadFields param, e.g., payment account details, price, etc.
     * Immutable fields are sourced from the original openOffer param.
     */
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5571#pullrequestreview-682391610
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210613/dc724baf/attachment.htm>


More information about the bisq-github mailing list