[bisq-network/bisq] Add new api method 'editoffer' (#5572)

[Stan]

To help review from bottom to top, commits are listed here in bottom to top order.

- 1daf4715f843acdd816c90ee9ae0bf5aaf630a93 Add `OfferInfo` field `isActivated`, rpc `EditOffer` to `grpc.proto`

- 2b8b53bba86579d71e184aac38531e15f462084b Add server/core `editOffer`, adjust` getMyOffer(s)` impls
  Add `editOffer` to `GrpcOffersService`, `CoreApi`, `CoreOffersService`.
  Set `editOffer` call rate meter to 1 / minute.
  Use new `EditOfferValidator` to verify `editOffer` params OK.
  Adust `getMyOffer(s)` rpc impl and `OfferInfo` model to use `OpenOffer` for accessing activation state and trigger price.

- 9231e48c439debc44213132e4b3a7f540503cad0 Refactor GrpcClient: request building code moved into `bisq.cli.request` pkg
  Reduces size of `GrpcClient` while allowing for new, bot-friendly variations of the new grpc.editOffer method.  (Various combinations of `editoffer` parameters are allowed and disallowed; the bot-friendly grpc.editOffer variations help disambiguate those parameter combinations.)

- d2939cc5676ce840d6af771d0321b0ffe2579b7c Add new `EditOfferOptionParser` & test

- 2344285ed3d7afd098a2bcc5920d8e5083720d88 Add `editoffer` method help

- be249c5e795065c627afe320cd9aa01ab2121894 Add `editoffer` to CLI

- 929b28cb8cb1667f0d64d3eb1bd017e56ee2d37a Add `editoffer` api tests & minor apitest refactoring

This is the 3rd in a series of PRs, starting at https://github.com/bisq-network/bisq/pull/5570
https://github.com/bisq-network/bisq/pull/5571 Should be reviewed/merged before this one. 

The new `editoffer` method works, and is documented in `editoffer-help.txt`,  but some follow up work is needed.  
Next PR(s) will be:
- Adjust `getmyoffer(s)` CLI output for new '`enabled`' and '`trigger-price`' columns.
- Adjust apitest trading scripts to new `getmyoffer(s) `CLI output.
- Adjust apitest user guide for new `editoffer`, and to new `getmyoffer(s)` CLI output.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5572

-- Commit Summary --

  * Remove commented out test
  * Remove unsupported create CHASE_QUICK_PAY apitest case
  * Refactor EditOfferDataModel for new editoffer api method
  * Fix comment
  * Add OfferInfo field isActivated, rpc EditOffer to proto
  * Add server/core editOffer, adjust getMyOffer(s) impls
  * Refactor GrpcClient: request builders moved bisq.cli.request pkg
  * Add new EditOfferOptionParser and test
  * Add editoffer method help
  * Add editoffer to CLI
  * Add editoffer api tests & minor apitest refactoring
  * Remove chase quickpay acct test
  * Remove unused import

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (50)
    M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (70)
    A apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (429)
    M apitest/src/test/java/bisq/apitest/method/payment/CreatePaymentAccountTest.java (23)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (3)
    A apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (167)
    M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (21)
    M apitest/src/test/java/bisq/apitest/scenario/PaymentAccountTest.java (1)
    M apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/bot/RandomOffer.java (9)
    M cli/src/main/java/bisq/cli/CliMain.java (42)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (63)
    M cli/src/main/java/bisq/cli/GrpcClient.java (377)
    M cli/src/main/java/bisq/cli/Method.java (1)
    M cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java (4)
    A cli/src/main/java/bisq/cli/opts/EditOfferOptionParser.java (264)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (2)
    A cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (317)
    A cli/src/main/java/bisq/cli/request/PaymentAccountsServiceRequest.java (85)
    A cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (94)
    A cli/src/main/java/bisq/cli/request/WalletsServiceRequest.java (192)
    A cli/src/test/java/bisq/cli/opt/EditOfferOptionParserTest.java (325)
    M cli/src/test/java/bisq/cli/opt/OptionParsersTest.java (2)
    M core/src/main/java/bisq/core/api/CoreApi.java (43)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (156)
    A core/src/main/java/bisq/core/api/EditOfferValidator.java (135)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (22)
    A core/src/main/java/bisq/core/offer/MutableOfferPayloadFields.java (89)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (47)
    A core/src/main/resources/help/editoffer-help.txt (95)
    M core/src/test/java/bisq/core/payment/PaymentAccountsTest.java (17)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (30)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (49)
    M proto/src/main/proto/grpc.proto (32)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5572.patch
https://github.com/bisq-network/bisq/pull/5572.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210613/b77d703b/attachment-0001.htm>