[bisq-network/bisq] Add hint to upgrade to tor v3 (#5573)

Christoph Atteneder notifications at github.com
Mon Jun 14 17:24:38 CEST 2021

If the node is in a state where an upgrade to a Tor v3 address can be done it displays a informational prompt.

![Bildschirmfoto 2021-06-14 um 17 18 33](https://user-images.githubusercontent.com/170962/121916821-c90d0800-cd34-11eb-8177-542869f3b10c.png)

@m52go ☝️ This needs some native speaker love.

I'll check this state on application start and when the last open trade is completed. I wanted to do this for closed disputes as well, but the data structure in place would force me to scatter check codes on multiple places which would make it burdensome to remove after the transition is complete.

To have a graceful upgrade proces nodes with a Tor v2 address won't be able to take offers anymore starting with August 15, 2020 (2 months before the Tor v2 support is dropped). Also their offers won't be visible to anyone else at that point.

I also added some unrelated checks to this upgrade process, that you can only reopen trades and disputes if you have the same local onion address to prevent communication issues that would go by without notice.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Only allow dispute to be reopened if local node address matches contract node address
  * Only allow failed trade to be moved to pending trades if local node address matches contract
  * Display a tor node address v3 upgrade prompt
  * Remove stale "NEW" badge on settings
  * Prevent nodes with Tor v2 address to participate in trading
  * Prevent reopen of disputes with tor node v2 addresses after cut off date
  * Not require Tor v3 addresses on Regtest

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqHeadlessApp.java (1)
    M core/src/main/java/bisq/core/app/BisqSetup.java (51)
    M core/src/main/java/bisq/core/offer/OfferRestrictions.java (11)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (8)
    M core/src/main/resources/i18n/displayStrings.properties (12)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (15)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (9)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesDataModel.java (31)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesView.java (10)
    M desktop/src/main/java/bisq/desktop/main/presentation/SettingsPresentation.java (1)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeView.java (34)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/agent/DisputeAgentView.java (5)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/agent/arbitration/ArbitratorView.java (4)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/agent/mediation/MediatorView.java (4)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/agent/refund/RefundAgentView.java (4)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/client/DisputeClientView.java (9)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/client/arbitration/ArbitrationClientView.java (5)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/client/mediation/MediationClientView.java (4)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/client/refund/RefundClientView.java (4)
    M p2p/src/main/java/bisq/network/utils/Utils.java (4)
    A p2p/src/test/java/bisq/network/utils/UtilsTest.java (36)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210614/12e7fa09/attachment-0001.htm>

More information about the bisq-github mailing list