[bisq-network/bisq] PriceNode: exclude currencies via config (#5582)

jmacxx notifications at github.com
Tue Jun 22 23:23:50 CEST 2021


This allows the PriceNode to configure certain currencies as not quoted, i.e. will not be delivered in its service API.  By doing so, those markets can self-discover the price the same way as is already done in BSQ/BTC market.

Fixes #5581 


### Config

Added to `application.properties`

    bisq.price.fiatcurrency.excluded=LBP,ARS
    bisq.price.cryptocurrency.excluded=



### Code changes: 

- get Environment object from Spring framework.
- parse & validate any currencies specified in the `application.properties` file.
- exclude currencies from the exchange supported fiat currency / crypto currency lists.
- log details of currencies excluded via configuration.
- add tests for the above.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5582

-- Commit Summary --

  * PriceNode: exclude currencies via config

-- File Changes --

    M build.gradle (1)
    M pricenode/src/main/java/bisq/price/spot/ExchangeRateProvider.java (59)
    M pricenode/src/main/java/bisq/price/spot/providers/BTCMarkets.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Binance.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Bitbay.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/BitcoinAverage.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Bitfinex.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Bitflyer.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Bitstamp.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/CoinGecko.java (11)
    M pricenode/src/main/java/bisq/price/spot/providers/CoinMarketCap.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Coinone.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Coinpaprika.java (7)
    M pricenode/src/main/java/bisq/price/spot/providers/Exmo.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Huobi.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/IndependentReserve.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Kraken.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Luno.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/MercadoBitcoin.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Paribu.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Poloniex.java (5)
    M pricenode/src/main/java/bisq/price/spot/providers/Quoine.java (5)
    M pricenode/src/main/resources/application.properties (2)
    M pricenode/src/test/java/bisq/price/AbstractExchangeRateProviderTest.java (12)
    M pricenode/src/test/java/bisq/price/spot/ExchangeRateServiceTest.java (81)
    M pricenode/src/test/java/bisq/price/spot/providers/BTCMarketsTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/BinanceTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/BitbayTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/BitfinexTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/BitflyerTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/BitstampTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/CoinGeckoTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/CoinoneTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/CoinpaprikaTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/ExmoTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/HuobiTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/IndependentReserveTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/KrakenTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/LunoTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/MercadoBitcoinTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/ParibuTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/PoloniexTest.java (4)
    M pricenode/src/test/java/bisq/price/spot/providers/QuoineTest.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5582.patch
https://github.com/bisq-network/bisq/pull/5582.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5582
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210622/89d9a810/attachment.htm>


More information about the bisq-github mailing list