[bisq-network/bisq] Is the trade protocol upgraded? (#5590)

typhu-xyz notifications at github.com
Tue Jun 29 13:54:27 CEST 2021


<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team over at https://keybase.io/team/Bisq
-->

### Description

Just upgraded to 1.7.0. Realized that 'trade protocol' has become 4. Looked through code (for 1.7.0) and see it's still clearly 3. Dug into the installed jar file and found it's 4 there (somehow). The way I upgraded is via downloading the exe from the official site. The PGP signature looks correct.

#### Version

Version{VERSION=1.7.0, P2P_NETWORK_VERSION=1, LOCAL_DB_VERSION=1, TRADE_PROTOCOL_VERSION=4, BASE_CURRENCY_NETWORK=0, getP2PNetworkId()=10}

### Steps to reproduce

<!--if you can reliably reproduce the bug, list the steps here  -->

### Expected behaviour

It seems to me that the trade protocol has not really upgraded. But it could be that I've missed something in the source code.

### Actual behaviour

<!-- explain what happened instead of the expected behaviour -->

### Screenshots

<!--Screenshots if gui related, drag and drop to add to the issue -->

#### Device or machine

<!-- device/machine used, operating system -->



#### Additional info

<!-- Additional information useful for debugging (e.g. logs) -->


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5590
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210629/b33f05d4/attachment.htm>


More information about the bisq-github mailing list