[bisq-network/bisq] Fix CLI number opt validation, improve server-not-up msg (#5259)

[Stan]

- Fix `--tx-fee-rate` opt validation bug.

- Tell user what option value is not a number, if validation fails.

- Append ", server may not be running" text to "io exception" exception msg.


Credit to keybase's `@btc_contributor` for finding the `tx-fee-rate` opt validation bug during api beta testing.

PR https://github.com/bisq-network/bisq/pull/5250 must be reviewed/merged before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5259

-- Commit Summary --

  * Display buyer's cost in api's gettrade output
  * Merge branch 'master' into 01-show-cost-in-trade-output
  * Use the logger of the gRPC service throwing an exception
  * Permit some gRPC excptions to be logged only as warning
  * Log 'trade not found' a warning instead of full stack trace
  * Fix test bug
  * Clean up call rate meter config file in test teardown
  * Fix test bug
  * Fix call rate metering interceptor bug
  * Make test call rate = default call rate
  * No need to wait, default+test call rate > 2x / second
  * Remove unused import
  * Adjust mainnet bats test to default rate meter interceptors
  * Wait 3 secs after removing password (for wallet save)
  * Fix getunusedbsqaddress test
  * Improve interceptor's rate metering key definition and lookup
  * Fix CLI number opt validation, improve server-not-up msg

-- File Changes --

    M apitest/scripts/mainnet-test.sh (22)
    M apitest/scripts/trade-simulation-utils.sh (12)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (54)
    M apitest/src/test/java/bisq/apitest/method/CallRateMeteringInterceptorTest.java (41)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (3)
    M apitest/src/test/java/bisq/apitest/scenario/StartupTest.java (12)
    M cli/src/main/java/bisq/cli/CliMain.java (42)
    M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (10)
    M cli/src/main/java/bisq/cli/TradeFormat.java (33)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcDisputeAgentsService.java (13)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcExceptionHandler.java (18)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcGetTradeStatisticsService.java (12)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcHelpService.java (9)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (28)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (24)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcPriceService.java (9)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcShutdownService.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (32)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcVersionService.java (9)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (60)
    M daemon/src/main/java/bisq/daemon/grpc/interceptor/CallRateMeteringInterceptor.java (22)
    M daemon/src/main/java/bisq/daemon/grpc/interceptor/GrpcCallRateMeter.java (5)
    M daemon/src/test/java/bisq/daemon/grpc/interceptor/GrpcServiceRateMeteringConfigTest.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5259.patch
https://github.com/bisq-network/bisq/pull/5259.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5259
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210301/1674ff46/attachment-0001.htm>