[bisq-network/bisq] Fix required opt validation bugs in CLI (#5274)

Stan notifications at github.com
Fri Mar 5 16:25:41 CET 2021


@ghubstan commented on this pull request.

The last part of commit d01a7b7feec7167b66ec808529d2e63ffe248442 's message is incorrect.  Commit d01a7b7feec7167b66ec808529d2e63ffe248442 makes _empty_ opt values invalid, and throws an exception with the conventional `no <opt> specified` error message. Before this change, the CLI's opt parser accepted `--offer-id=` as a valid option, with an empty value.

The _next_ commit makes the option parser throw option parser exceptions due to  _missing (not empty)_ option values.  The next commit will result in a stylistically consistent error message printed to the console when `--offer-id` is present without an `=` delimiter (as if it were a no-arg option).



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5274#pullrequestreview-605334885
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210305/65f9deaf/attachment.htm>


More information about the bisq-github mailing list