[bisq-network/bisq] Validate offer <-> payment-acct in createoffer (#5284)

Sun Mar 7 23:54:43 CET 2021

This change prohibits creation of new offers with incompatible payment accounts with the api.

- `PaymentAccountUtil` 
  Renamed isAnyTakerPaymentAccountValidForOffer -> isAnyPaymentAccountValidForOffer.
  Renamed isTakerPaymentAccountValidForOffer -> isPaymentAccountValidForOffer.
  Deleted commented code.

- `PaymentAccounts`: Adjusted to PaymentAccountUtil method name changes.

- `OfferFilter`: Adjusted to PaymentAccountUtil method name changes.

- `OfferBookViewModelTest`: Adjusted to PaymentAccountUtil method name changes.

- Added `CoreOffersService#verifyPaymentAccountIsValidForOffer`

- `ValidateCreateOfferTest`, `OfferTest`: Added test cases.

PR https://github.com/bisq-network/bisq/pull/5274 should be reviewed & merged before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5284

-- Commit Summary --

  * Display buyer's cost in api's gettrade output
  * Merge branch 'master' into 01-show-cost-in-trade-output
  * Use the logger of the gRPC service throwing an exception
  * Permit some gRPC excptions to be logged only as warning
  * Log 'trade not found' a warning instead of full stack trace
  * Fix test bug
  * Clean up call rate meter config file in test teardown
  * Fix test bug
  * Fix call rate metering interceptor bug
  * Make test call rate = default call rate
  * No need to wait, default+test call rate > 2x / second
  * Remove unused import
  * Adjust mainnet bats test to default rate meter interceptors
  * Wait 3 secs after removing password (for wallet save)
  * Fix getunusedbsqaddress test
  * Improve interceptor's rate metering key definition and lookup
  * Fix CLI number opt validation, improve server-not-up msg
  * Fix tx-fee-rate formatting (and math) bug in cli/CurrencyFormat
  * Remove warning supression
  * Add link to api-beta-test-guide.md
  * Explain how to manually register test dispute agents
  * Fix opt validation bugs in CLI
  * Update cli getoffers smoke test to posix style opts
  * Improve required-argument opt validation
  * Add jupiter test support to :cli subproject
  * Add new cli option parser test
  * Handle require-arg options missing the = sign
  * Validate offer <-> payment-acct in createoffer

-- File Changes --

    M apitest/docs/README.md (1)
    M apitest/docs/api-beta-test-guide.md (19)
    M apitest/scripts/mainnet-test.sh (22)
    M apitest/scripts/trade-simulation-utils.sh (12)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (54)
    M apitest/src/test/java/bisq/apitest/method/CallRateMeteringInterceptorTest.java (41)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (37)
    M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/scenario/StartupTest.java (12)
    M build.gradle (11)
    M cli/src/main/java/bisq/cli/CliMain.java (42)
    M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (10)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (5)
    M cli/src/main/java/bisq/cli/TradeFormat.java (33)
    M cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java (25)
    M cli/src/main/java/bisq/cli/opts/CancelOfferOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/CreateOfferOptionParser.java (34)
    M cli/src/main/java/bisq/cli/opts/CreatePaymentAcctOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/GetAddressBalanceOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/GetBTCMarketPriceOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/GetOfferOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/GetOffersOptionParser.java (11)
    M cli/src/main/java/bisq/cli/opts/GetPaymentAcctFormOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/GetTradeOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/GetTransactionOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/RegisterDisputeAgentOptionParser.java (11)
    M cli/src/main/java/bisq/cli/opts/RemoveWalletPasswordOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/SendBsqOptionParser.java (10)
    M cli/src/main/java/bisq/cli/opts/SendBtcOptionParser.java (10)
    M cli/src/main/java/bisq/cli/opts/SetTxFeeRateOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/SetWalletPasswordOptionParser.java (5)
    M cli/src/main/java/bisq/cli/opts/TakeOfferOptionParser.java (11)
    M cli/src/main/java/bisq/cli/opts/UnlockWalletOptionParser.java (6)
    M cli/src/main/java/bisq/cli/opts/WithdrawFundsOptionParser.java (11)
    M cli/src/test/java/bisq/cli/GetOffersSmokeTest.java (16)
    A cli/src/test/java/bisq/cli/opt/OptionParsersTest.java (173)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (12)
    M core/src/main/java/bisq/core/offer/OfferFilter.java (2)
    M core/src/main/java/bisq/core/payment/PaymentAccountUtil.java (31)
    M core/src/main/java/bisq/core/payment/PaymentAccounts.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcDisputeAgentsService.java (13)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcExceptionHandler.java (18)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcGetTradeStatisticsService.java (12)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcHelpService.java (9)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (28)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (24)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcPriceService.java (9)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcShutdownService.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (32)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcVersionService.java (9)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (60)
    M daemon/src/main/java/bisq/daemon/grpc/interceptor/CallRateMeteringInterceptor.java (22)
    M daemon/src/main/java/bisq/daemon/grpc/interceptor/GrpcCallRateMeter.java (5)
    M daemon/src/test/java/bisq/daemon/grpc/interceptor/GrpcServiceRateMeteringConfigTest.java (2)
    M desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java (44)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5284.patch
https://github.com/bisq-network/bisq/pull/5284.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5284
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210307/2ff3dedd/attachment-0001.htm>