[bisq-network/bisq] Fix copy of BankName value + BranchId/BankId (#5231)

[Christoph Atteneder]

@ripcurlx requested changes on this pull request.

NACK - Please see my comments on the naming. Also for the future please have a look at https://chris.beams.io/posts/git-commit/. I'm not a great commit message writer myself, but I think there is some potential to grow :wink:

> @@ -1519,6 +1519,15 @@ private static Label getTopLabel(String title) {
         return addTopLabelTextFieldWithCopyIcon(gridPane, rowIndex, colIndex, title, value, -Layout.FLOATING_LABEL_DISTANCE);
     }
 
+    public static Tuple2<Label, TextFieldWithCopyIcon> addCompactTopLabelTextFieldWithCopyIcon(GridPane gridPane,
+                                                                                               int rowIndex,
+                                                                                               int colIndex,
+                                                                                               String title,
+                                                                                               String value,
+                                                                                               boolean withoutBeforeSlash) {

When used with code completion this naming `withoutBeforeSlash` is not very intuitive. Maybe rename it to `onlyCopyTextAfterDelimiter` 

> @@ -39,7 +39,7 @@
     private final StringProperty text = new SimpleStringProperty();
     private final TextField textField;
     private boolean copyWithoutCurrencyPostFix;
-
+    private boolean copyWithoutBeforeSlash;

As this code is independent of `/` I think it would be better to name it to `copyTextAfterDelimiter`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5231#pullrequestreview-609914300
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210311/bbd7ef5b/attachment.htm>