[bisq-network/bisq] Fix BankId leak (#5234)

[Christoph Atteneder]

@ripcurlx requested changes on this pull request.

NACK - please see my comments.

> @@ -253,21 +253,20 @@ private void addContent() {
             addConfirmationLabelLabel(gridPane, ++rowIndex, Res.get("offerDetailsWindow.myTradingAccount"), myPaymentAccount.getAccountName());
         } else {
             final String method = Res.get(paymentMethod.getId());
-            String methodWithBankId = method + bankId;
             String paymentMethodLabel = Res.get("shared.paymentMethod");
             if (countryCode != null && (isNationalBanks || isSpecificBanks || isSepa)) {

For specific banks payment method we do want to show the bank name and/or id as it would be otherwise for someone to match ones offer using this payment method.

>              String paymentMethodLabel = Res.get("shared.paymentMethod");
             if (countryCode != null && (isNationalBanks || isSpecificBanks || isSepa)) {
                 if (BankUtil.isBankIdRequired(countryCode))
                     addConfirmationLabelLabel(gridPane, ++rowIndex,
-                            paymentMethodLabel + " " + Res.get("offerDetailsWindow.offererBankId"),

If you remove a translations please also remove it from `displayStrings.properties`. Otherwise we'll have more and more unnecessary strings to be translated. But in this case you probably need them anyways for the specific banks payment method

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5234#pullrequestreview-610581043
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210312/e6eb428e/attachment.htm>