[bisq-network/bisq] Verify maker & taker fee transactions via Mempool lookup (#5160)

jmacxx notifications at github.com
Sun Mar 14 04:19:48 CET 2021


@jmacxx commented on this pull request.



> @@ -462,6 +463,7 @@ private void updateButtonDisableState() {
         boolean inputDataValid = isBtcInputValid(amount.get()).isValid
                 && dataModel.isMinAmountLessOrEqualAmount()
                 && !dataModel.isAmountLargerThanOfferAmount()
+                && dataModel.mempoolStatus.get() >= 0

Initially I had it not blocking the next button, but depending on the speed of the mempool response you'd be told about a bad offer sometimes but not others.  So it felt unpredictable, and since the `checkOfferAvailabilityRequest` already blocks the next button I thought it best to have the mempool check do the same.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5160#discussion_r593834295
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210313/c36b24e7/attachment-0001.htm>


More information about the bisq-github mailing list