[bisq-network/bisq] Avoid NPE due to null fee while wrapping tx in TxInfo (#5302)
Stan
notifications at github.com
Sun Mar 14 16:13:47 CET 2021
Add debugging convenience to core api model's `TxInfo`.
PR https://github.com/bisq-network/bisq/pull/5294 should be reviewed/merged before this one.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5302
-- Commit Summary --
* Adjust protos for takeoffer error handing
* Inject CoreContext into OpenOfferManager, adjust test
* Adjust grpc & core services to new takeoffer error handling
* Convert AvailabilityResult to error msg when takeoffer fails
* Add missing grpc exception catch blocks
* Derive AvailabilityResult from Task errorMessage
* Merge branch 'master' into 01-fix-takeoffer-err-handling
* Avoid NPE due to null fee while wrapping tx in TxInfo
-- File Changes --
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (62)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (72)
M cli/src/main/java/bisq/cli/GrpcClient.java (72)
M core/src/main/java/bisq/core/api/CoreApi.java (7)
M core/src/main/java/bisq/core/api/CoreTradesService.java (10)
M core/src/main/java/bisq/core/api/model/TxInfo.java (70)
M core/src/main/java/bisq/core/offer/AvailabilityResult.java (9)
M core/src/main/java/bisq/core/offer/OpenOfferManager.java (12)
M core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java (72)
A daemon/src/main/java/bisq/daemon/grpc/GrpcErrorMessageHandler.java (122)
M daemon/src/main/java/bisq/daemon/grpc/GrpcExceptionHandler.java (19)
M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (35)
M proto/src/main/proto/grpc.proto (1)
M proto/src/main/proto/pb.proto (1)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5302.patch
https://github.com/bisq-network/bisq/pull/5302.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5302
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210314/239e59de/attachment.htm>
More information about the bisq-github
mailing list