[bisq-network/bisq] Add custom withdrawal transaction fee options on Send funds (BTC) (#5312)

Mawueli Kofi Adzoe notifications at github.com
Mon Mar 15 17:33:44 CET 2021


@wallclockbuilder requested changes on this pull request.

Add tests so we know its working and also get notified if something breaks this in the future.

> @@ -221,6 +228,52 @@ public void initialize() {
         withdrawMemoTextField = addTopLabelInputTextField(gridPane, ++rowIndex,
                 Res.get("funds.withdrawal.memoLabel", Res.getBaseCurrencyCode())).second;
 
+        Tuple3<Label, InputTextField, ToggleButton> customFeeTuple = addTopLabelInputTextFieldSlideToggleButton(gridPane, ++rowIndex,

You're reorganising 40 lines of code(more than 7lines i.e. readable). Where are the unit tests and/or end-to-end tests for this?

> @@ -221,6 +228,52 @@ public void initialize() {
         withdrawMemoTextField = addTopLabelInputTextField(gridPane, ++rowIndex,
                 Res.get("funds.withdrawal.memoLabel", Res.getBaseCurrencyCode())).second;
 
+        Tuple3<Label, InputTextField, ToggleButton> customFeeTuple = addTopLabelInputTextFieldSlideToggleButton(gridPane, ++rowIndex,

That way we know it works all the time, and we also know when it gets accidentally broken by some other feature.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5312#pullrequestreview-612401502
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210315/081fdb93/attachment-0001.htm>


More information about the bisq-github mailing list