[bisq-network/bisq] Allow resend of fiat payment sent message in exceptional circumstance (#5320)

[jmacxx]

This is a proposed temporary solution the number 1 mediation issue of "Unable to confirm payment received".
tldr; Allow the Buyer able to re-send the "Fiat payment initiated" message by the following method.


**Current problem:**

- Buyer sends "Fiat payment initiated" message.
- Seller either does not receive it or somehow has a problem processing it (as was the case in support case id=YCWGPDVA)
- Buyer is unable to re-send the "Fiat payment initiated" message.
 


**Proposed solution:**

- Buyer sends "Fiat payment initiated" message.
- Seller either does not receive it or somehow has a problem processing it.
- Either party opens a support ticket, explains the problem (Seller cannot confirm, buyer cannot re-send "Fiat payment initiated")
- Mediator closes the ticket as "Bug", advising both to reject mediation, and the buyer to double-click on Trade Step 2 line item in the GUI.
- Buyer is then prompted to re-send the "Fiat payment initiated" message.
- Seller sees the subsequent "Fiat payment initiated" message and the trade can continue.

 

Internally, the code will check that if user double clicks on buyer step 2 (Start Payment), and if a dispute has been closed, then it will move the trade state back to BUYER_CONFIRMED_IN_UI_FIAT_PAYMENT_INITIATED.  This will then cause the existing workflow to show a button requesting that the trader resend the message.

Protection from misuse is added by only allowing this workflow after a dispute ticket has been closed.  It also allows mediators to observe if this solution really does address the problem.

---


After opening a support ticket, mediator will instruct buyer to double-click on step 2:

![image](https://user-images.githubusercontent.com/47253594/111360657-03460b00-865b-11eb-8f00-225973f195ea.png)

Then buyer is able to re-send the payment started message:

![image](https://user-images.githubusercontent.com/47253594/111360770-28d31480-865b-11eb-8ddd-9fcdad1dced3.png)



You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5320

-- Commit Summary --

  * allow resend of fiat payment sent message in exceptional circumstance

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/BuyerSubView.java (18)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeWizardItem.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5320.patch
https://github.com/bisq-network/bisq/pull/5320.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5320
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210316/aebf3c94/attachment.htm>