[bisq-network/bisq] Prevent trading when not connected to the Bitcoin network (#5325)

[jmacxx]

It is currently possible to create and take offers while not connected to the bitcoin network.

This should have been fixed by https://github.com/bisq-network/bisq/pull/4764 but that PR only considered the scenario where chainheight from the DAO was stale.  

The fix is to also handle the other part of the equation, when the **chainheight of bitcoin network peers is stale**.  



---

Instances of this problem have been experienced with offers that have transactions not found by blockexplorers, as described in https://github.com/bisq-network/bisq/issues/5151 and https://github.com/bisq-network/bisq/issues/3305.  


---


**To reproduce the issue:**

- Start Bisq, specifying a bitcoin node address that is not running a node.  (For regtest see `DEFAULT_REGTEST_HOST`)
- Bisq will start up and display "Connecting to Bitcoin network" in the footer bar.
- Create offers, take offers.  No error messages are displayed.


**To verify the fix:**

- Start Bisq, specifying a bitcoin node address that is not running a node.  (For regtest see `DEFAULT_REGTEST_HOST`)
- Bisq will start up and display "Connecting to Bitcoin network" in the footer bar.
- Attempt to create offers, take offers.  You will be informed as that Bisq is not in sync with the network.

![image](https://user-images.githubusercontent.com/47253594/111535603-4aa1c980-8737-11eb-8b9f-c4ac4b06eaf8.png)


Network Settings:

![image](https://user-images.githubusercontent.com/47253594/111537770-d9174a80-8739-11eb-8b9e-40f938f33487.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5325

-- Commit Summary --

  * handle case where bitcoind chain height is stale

-- File Changes --

    M core/src/main/java/bisq/core/btc/setup/WalletsSetup.java (2)
    M core/src/main/resources/i18n/displayStrings.properties (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5325.patch
https://github.com/bisq-network/bisq/pull/5325.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5325
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210317/65c39ac0/attachment-0001.htm>