[bisq-network/bisq] BSQ trading fee calculated incorrectly (#5329)

[jmacxx]

Some offers pay an incorrect BSQ fee.

Here is an example of the discrepancies from today's offer book.  Some have underpaid, others have overpaid.

![image](https://user-images.githubusercontent.com/47253594/111669793-26042b00-87e5-11eb-932a-d0bd9b04c51d.png)

The fee rate is chosen based on the block height at the time the offer is created.  For example, an offer created at block height 673810 would use the fee rate of 7.53 BSQ per bitcoin.

![image](https://user-images.githubusercontent.com/47253594/111671426-ed655100-87e6-11eb-9c4a-f0b7a3d53d68.png)

A small but significant subset of offers have not chosen the correct fee rate.  How can this happen?

Looking at the highlighted onion addresses, it seems that when a node chooses an incorrect rate, it is consistent in choosing the same incorrect fee rate for subsequent offers.

Attn: @chimp1984 @ripcurlx 
[feeDiscrepancies_20210318.xlsx](https://github.com/bisq-network/bisq/files/6166243/feeDiscrepancies_20210318.xlsx)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5329
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210318/28f6de0d/attachment-0001.htm>