[bisq-network/bisq] Disambiguate payment acct json form's "country" field (#5330)

[Stan]

Make it clear the user needs to enter a two letter country code in the api's payment account json form's `country` field, not a country name.  A blank payment account json form now has a  `country` default value = `your two letter country code`.

The json form's field name was not changed to countryCode for the following reason:

The API's payment account forms are dynamically generated using reflection, and `PaymentAccount` class hierarchy `@Setter` methods determine which form fields are included or excluded.  Reflection and `@Setter` methods are also used when reading completed json forms, to set the field values on a new PaymentAccount instance before it is persisted.

`CountryBasedPaymentAccount` subclasses like `F2FAccount` have a `country` field and a `@Setter`, not a countryCode field, hence this shortcut to informing the user the country field value is a country-code.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5330

-- Commit Summary --

  * Disambiguate payment acct json form's "country" field

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/payment/AbstractPaymentAccountTest.java (5)
    M core/src/main/java/bisq/core/api/model/PaymentAccountTypeAdapter.java (5)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5330.patch
https://github.com/bisq-network/bisq/pull/5330.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5330
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210318/df141eba/attachment-0001.htm>