[bisq-network/bisq] Fix API startup's wallet.init failure when wallet is encrypted (#5337)

[Stan]

This bug fix makes sure encrypted wallet initialization happens during startup, without prompting the user for a wallet password.

- Block UI popups in api startup's encrypted wallet init.
Running the UI's `walletPasswordHandler` during wallet initialization will block the API's wallet initialization.  This change ensures an encrypted wallet does not trigger `walletPasswordHandler.run()` if `isApiUser=true` during startup.


- Set `WalletsManager` key in first `CoreWalletsService#unlockWallet` call.
This is necessary because the key cannot be set during api daemon startup, which does happen during the UI's startup.  See commit eb15fda229bd9481b11844ee95f2243613842034.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5337

-- Commit Summary --

  * Block UI popups in api startup's encrypted wallet init
  * Set WalletsManager key if missing
  * Fix typo
  * Remove log statement, add comment

-- File Changes --

    M core/src/main/java/bisq/core/api/CoreWalletsService.java (49)
    M core/src/main/java/bisq/core/app/AppStartupState.java (2)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5337.patch
https://github.com/bisq-network/bisq/pull/5337.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5337
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210320/5771c5e5/attachment.htm>