[bisq-network/bisq] Fee validation leniency using old DAO param values (#5347)

[jmacxx]

Some Bisq clients are stuck on an invalid DAO state and are paying fees on an old schedule.

Per https://github.com/bisq-network/bisq/issues/5329#issuecomment-803223859 : a paid fee will be considered valid if it can be derived from any of the DAO parameter changelist.  

After implementing this change, the OfferBook discrepancies listed in #5329 are reduced to zero.

---

The essence of the leniency check is this:

![image](https://user-images.githubusercontent.com/47253594/112208143-06ef0a00-8be6-11eb-885d-6f915134fb64.png)



You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5347

-- Commit Summary --

  * Fee validation leniency using old DAO param values

-- File Changes --

    M core/src/main/java/bisq/core/dao/state/DaoStateService.java (10)
    M core/src/main/java/bisq/core/provider/mempool/TxValidator.java (67)
    M core/src/test/java/bisq/core/provider/mempool/TxValidatorTest.java (124)
    M core/src/test/resources/bisq/core/provider/mempool/badOfferTestData.json (3)
    M core/src/test/resources/bisq/core/provider/mempool/offerTestData.json (9)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5347.patch
https://github.com/bisq-network/bisq/pull/5347.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5347
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210323/4748355c/attachment.htm>