[bisq-network/bisq] Review changes for Disputes GUI (#5349)

jmacxx notifications at github.com
Wed Mar 24 05:10:16 CET 2021


- highlight trade period end using an appropriate CSS alert style
- system messages to show in chat unread message count

---
https://github.com/bisq-network/bisq/pull/5160#issuecomment-801161625

> Better would be e.g. to create a new class .alert without underline and hand, so it doesn't look like a link.

Done.

> And one more thing I missed in the other PR and feels a little bit weird for the user. If a dispute is closed you get the notification popup. When you click on it, it opens the support section and the issue is selected. But it is greyed out and users might not know what to do. Maybe it is better to open in this case automatically the same action as a double click would trigger. WDYT?

I tried this and did not like it.   There are already too many things that pop up, and having the first closed dispute pop open its chat view when entering support is very counter-intuative.  NACK

> Also it would be good to show a (1) badge over the chat icon for the system message, so people are looking into it. In the past the chat was open by default in-line. So at least a notification would be good.

Done.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5349

-- Commit Summary --

  * Review changes for Disputes GUI

-- File Changes --

    M core/src/main/java/bisq/core/support/dispute/Dispute.java (3)
    M desktop/src/main/java/bisq/desktop/bisq.css (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5349.patch
https://github.com/bisq-network/bisq/pull/5349.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5349
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210323/d65722b9/attachment.htm>


More information about the bisq-github mailing list